Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): more prompt template follow-ups #6762

Merged
merged 5 commits into from
Aug 20, 2024
Merged

fix(ui): more prompt template follow-ups #6762

merged 5 commits into from
Aug 20, 2024

Conversation

maryhipp
Copy link
Collaborator

@maryhipp maryhipp commented Aug 20, 2024 •
edited
Loading

Summary

  • add loading state to button when creating or updating a prompt template
  • fix badge styling when template name is long
  • fix extra slash in exports endpoint that UI calls
  • fix(ui): error handling if unable to convert image URL to blob

Related Issues / Discussions

QA Instructions

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added the frontend PRs that change frontend files label Aug 20, 2024
@maryhipp maryhipp changed the title fix(ui): add loading state to button when creating or updating a prompt template fix(ui): more prompt template follow-ups Aug 20, 2024
@psychedelicious psychedelicious enabled auto-merge (rebase) August 20, 2024 23:03
@psychedelicious psychedelicious force-pushed the maryhipp/loading-state-for-style-preset-form branch from aa16e04 to 0df44c9 Compare August 20, 2024 23:04
@psychedelicious psychedelicious merged commit 4f4ba7b into main Aug 20, 2024
14 checks passed
@psychedelicious psychedelicious deleted the maryhipp/loading-state-for-style-preset-form branch August 20, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious psychedelicious approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maryhipp @psychedelicious